Skip to content

Fix: Fabric Native Measure #55025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JacquesLeupin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Fabric Native Measure #55025

JacquesLeupin wants to merge 1 commit into from

Conversation

@JacquesLeupin
Copy link

@JacquesLeupin JacquesLeupin commented Jan 4, 2026 •
edited
Loading

Summary:

Fix Fabric UIManager.measure / measureInWindow returning shadow-tree coordinates on Android (and iOS), which breaks Pressability hit regions when the native view is moving (e.g. native-driven animations).

This fix is inspired by a potential solution proposed in #51621.

What changed

  • Route Fabric measure / measureInWindow through SchedulerDelegate so the platform can optionally measure the mounted native view on the UI thread.
  • Android: measure mounted View bounds (incl. transforms) and report back to C++/JS.
  • iOS: measure mounted UIView via convertRect and report back to C++/JS.
  • Keep existing DOM/shadow-tree measurement as a fallback.

Changelog:

[ANDROID] [FIXED] - Fabric measure / measureInWindow use mounted native view coordinates (fixes Pressable onPress during native-driven animations).
[IOS] [FIXED] - Fabric measure / measureInWindow use mounted native view coordinates.

Test Plan:

  • yarn test packages/react-native/Libraries/Pressability/__tests__/Pressability-test.js
  • RNTester:
    • Pressable → “Pressable with Animated Transform”
    • Verify onPress works while the view is animating (Android + iOS)

@meta-cla
Copy link

meta-cla bot commented Jan 4, 2026

Hi @JacquesLeupin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Jan 4, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 4, 2026
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 4, 2026
@JacquesLeupin
Copy link
Author

JacquesLeupin commented Jan 4, 2026 •
edited
Loading

This implementation routes measure through SchedulerDelegate to measure the mounted native view on the UI thread, and falls back to the existing shadow-tree values when native measurement isn’t possible. Note that on iOS/Android the callback may be invoked asynchronously (scheduled via the runtime scheduler) when the native-measure path is taken, which matches Paper’s callback-based semantics but may differ from Fabric’s previous “effectively synchronous” shadow-tree path.

@JacquesLeupin JacquesLeupin force-pushed the fix/fabric-native-measure branch from f8e40db to 6713027 Compare January 4, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JacquesLeupin @facebook-github-bot